langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #2991] fix: 'next' button unresponsive when uploading additional documents before previous batch completes #23947

New Issue
Closed
opened 2026-02-21 20:22:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:22:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/2991

State: closed
Merged: Yes

Description

This is a particularly interesting issue.

I've actually spent a considerable amount of time understanding how the entire upload component functions, ultimately identifying the problem, and now proposing a solution with this PR. Let me share the details step by step:

Firstly, what exactly is the issue?
When uploading files, if we select multiple files for batch uploading and, before this batch has finished uploading, add another batch of files, upon waiting for all network requests to finish, you'll notice that the “Next” button remains unclickable.

So, what is the underlying cause of this issue?
The main issue lies in fileListCopy, which is an outdated snapshot instead of the current fileListRef.current.

This isn't an issue for single batch uploads, but if new files are added during an upload, the updateFileList function in web/app/components/datasets/create/index.tsx updates the file list with the latest files.

However, updateFile uses fileListCopy to update post-upload information, leading to potential loss of data for files that have finished uploading due to this outdated copy.

The solution is straightforward: eliminate fileListCopy.
This effectively fixes the problem without affecting existing workflows.

PS. For maintainers who want to try to reproduce this issue, you can open Chrome > Dev Tools > Network > Slow 3G throttling, which helps to reproduce the problem quickly.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement，including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/2991 **State:** closed **Merged:** Yes --- # Description This is a particularly interesting issue. I've actually spent a considerable amount of time understanding how the entire upload component functions, ultimately identifying the problem, and now proposing a solution with this PR. Let me share the details step by step: **Firstly, what exactly is the issue?** When uploading files, if we select multiple files for batch uploading and, before this batch has finished uploading, add another batch of files, upon waiting for all network requests to finish, you'll notice that the “Next” button remains unclickable. **So, what is the underlying cause of this issue?** The main issue lies in `fileListCopy`, which is an outdated snapshot instead of the current `fileListRef.current`. This isn't an issue for single batch uploads, but if new files are added during an upload, the `updateFileList` function in `web/app/components/datasets/create/index.tsx` updates the file list with the latest files. However, `updateFile` uses `fileListCopy` to update post-upload information, leading to potential loss of data for files that have finished uploading due to this outdated copy. The solution is straightforward: eliminate fileListCopy. This effectively fixes the problem without affecting existing workflows. ------- PS. For maintainers who want to try to reproduce this issue, you can open Chrome > Dev Tools > Network > Slow 3G throttling, which helps to reproduce the problem quickly. Fixes # (issue) ## Type of Change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement，including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] TODO # Suggested Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:22:04 -05:00
yindo closed this issue 2026-02-21 20:22:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#23947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?