[PR #3128] fix: Turn off SWR automatic revalidation when window is focused #24001

Closed
opened 2026-02-21 20:22:10 -05:00 by yindo · 0 comments
Owner

Original Pull Request: https://github.com/langgenius/dify/pull/3128

State: closed
Merged: No


Description

Issues#3048 Why do we always trigger many requests every time we focus on the page ?

if using SWR to process data requests in React, set revalidateOnFocus=false in config is better.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Open any page
  2. Blur the page
  3. Focus the page
  4. See the network in browser's console

The network page of console is very refreshing

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/3128 **State:** closed **Merged:** No --- # Description [Issues#3048 Why do we always trigger many requests every time we focus on the page ?](https://github.com/langgenius/dify/issues/3084) if using SWR to process data requests in React, set revalidateOnFocus=false in config is better. Fixes # (issue) ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? 1. Open any page 2. Blur the page 3. Focus the page 4. See the network in browser's console The network page of console is very refreshing - [ ] TODO # Suggested Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:22:10 -05:00
yindo closed this issue 2026-02-21 20:22:10 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24001