langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #3490] Removed the mandatory check in the code that the username and password of the milvus configuration are not empty #24156

New Issue
Closed
opened 2026-02-21 20:22:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:22:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/3490

State: closed
Merged: No

Description

This change allows the username and password for Milvus to be optional, removing the mandatory validation that previously caused errors when these credentials were left blank. This adjustment aims to improve usability and flexibility in scenarios where Milvus does not require authentication, ensuring the application's smooth operation without unnecessary hindrances.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

You may initiate the code to verify the connection with a default empty Milvus instance.

**Original Pull Request:** https://github.com/langgenius/dify/pull/3490 **State:** closed **Merged:** No --- # Description This change allows the username and password for Milvus to be optional, removing the mandatory validation that previously caused errors when these credentials were left blank. This adjustment aims to improve usability and flexibility in scenarios where Milvus does not require authentication, ensuring the application's smooth operation without unnecessary hindrances. Fixes # (issue) ## Type of Change - Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? You may initiate the code to verify the connection with a default empty Milvus instance.
yindo added the pull-request label 2026-02-21 20:22:28 -05:00
yindo closed this issue 2026-02-21 20:22:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?