langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-24 13:06:09 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #3718] fix: toggling AppDetailNav causes unnecessary component rerenders #24248

New Issue
Closed
opened 2026-02-21 20:22:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:22:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/3718

State: closed
Merged: Yes

Description

When a state selector is not set, the component will render on every state change. Even if only extracting a specific state field using object destructuring, it will still respond to all state changes. This will cause some unnecessary component rerenders.

// no
const state = useAppStore()
// no
const { appDetail } = useAppStore()
// yes
const appDetail = useAppStore(state => state.appDetail)

create or createStore

The store created with create doesn't require context providers. In some cases, you may want to use contexts for dependency injection or if you want to initialize your store with props from a component. Because the normal store is a hook, passing it as a normal context value may violate the rules of hooks.

Type of Change

  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
**Original Pull Request:** https://github.com/langgenius/dify/pull/3718 **State:** closed **Merged:** Yes --- # Description When a state selector is not set, the component will render on every state change. Even if only extracting a specific state field using object destructuring, it will still respond to all state changes. This will cause some unnecessary component rerenders. ```ts // no const state = useAppStore() // no const { appDetail } = useAppStore() // yes const appDetail = useAppStore(state => state.appDetail) ``` `create` or `createStore` > The store created with create doesn't require context providers. In some cases, you may want to use contexts for dependency injection or if you want to initialize your store with props from a component. Because the normal store is a hook, passing it as a normal context value may violate the rules of hooks. ## Type of Change - [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
yindo added the pull-request label 2026-02-21 20:22:39 -05:00
yindo closed this issue 2026-02-21 20:22:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?