langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-27 11:11:21 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #3898] feat: update notion extractor #24319

New Issue
Closed
opened 2026-02-21 20:22:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:22:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/3898

State: closed
Merged: Yes

Description

see this post: https://github.com/langgenius/dify/discussions/3883

This PR combine all the blocks of a notion page into a single document. Headings are converted to the markdown style, so that user can use customized splitter to split it into chunks.
For example, \n## can be used to split by h2 (It may not work if there is a code block and comment in the page).

Anyway, from my experience, too many chunks and less content in each chunk result in poorly performance. This PR could make it better.

Type of Change

  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

A test script was added.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/3898 **State:** closed **Merged:** Yes --- # Description see this post: https://github.com/langgenius/dify/discussions/3883 This PR combine all the blocks of a notion page into a single document. Headings are converted to the markdown style, so that user can use customized splitter to split it into chunks. For example, `\n## ` can be used to split by h2 (It may not work if there is a code block and comment in the page). Anyway, from my experience, too many chunks and less content in each chunk result in poorly performance. This PR could make it better. ## Type of Change - [X] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement # How Has This Been Tested? A test script was added. # Suggested Checklist: - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] My changes generate no new warnings - [X] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [X] `optional` I have added tests that prove my fix is effective or that my feature works - [X] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:22:47 -05:00
yindo closed this issue 2026-02-21 20:22:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?