langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #4851] chore: fix invalid escape sequences by applying W605 rule #24670

New Issue
Closed
opened 2026-02-21 20:23:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:23:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/4851

State: closed
Merged: Yes

Description

api/services/workflow/workflow_converter.py:308
  /home/runner/work/dify/dify/api/services/workflow/workflow_converter.py:308: DeprecationWarning: invalid escape sequence '\{'
    request_body_json = request_body_json.replace('\{\{', '{{').replace('\}\}', '}}')

api/services/workflow/workflow_converter.py:308
  /home/runner/work/dify/dify/api/services/workflow/workflow_converter.py:308: DeprecationWarning: invalid escape sequence '\}'
    request_body_json = request_body_json.replace('\{\{', '{{').replace('\}\}', '}}')

api/core/splitter/text_splitter.py:704
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:704: DeprecationWarning: invalid escape sequence '\*'
    "\n\*+\n",

api/core/splitter/text_splitter.py:803
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:803: DeprecationWarning: invalid escape sequence '\*'
    "\n\*\*\*+\n",

api/core/splitter/text_splitter.py:816
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:816: DeprecationWarning: invalid escape sequence '\c'
    "\n\\\chapter{",

api/core/splitter/text_splitter.py:817
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:817: DeprecationWarning: invalid escape sequence '\s'
    "\n\\\section{",

api/core/splitter/text_splitter.py:818
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:818: DeprecationWarning: invalid escape sequence '\s'
    "\n\\\subsection{",

api/core/splitter/text_splitter.py:819
  /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:819: DeprecationWarning: invalid escape sequence '\s'
    "\n\\\subsubsection{",

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

  • pass the test_text_splitter tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/4851 **State:** closed **Merged:** Yes --- # Description - applying W605 rule (https://docs.astral.sh/ruff/rules/invalid-escape-sequence/) to auto-fix invalid escape sequences causing warning messages when running unit tests in CI jobs: ``` api/services/workflow/workflow_converter.py:308 /home/runner/work/dify/dify/api/services/workflow/workflow_converter.py:308: DeprecationWarning: invalid escape sequence '\{' request_body_json = request_body_json.replace('\{\{', '{{').replace('\}\}', '}}') api/services/workflow/workflow_converter.py:308 /home/runner/work/dify/dify/api/services/workflow/workflow_converter.py:308: DeprecationWarning: invalid escape sequence '\}' request_body_json = request_body_json.replace('\{\{', '{{').replace('\}\}', '}}') api/core/splitter/text_splitter.py:704 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:704: DeprecationWarning: invalid escape sequence '\*' "\n\*+\n", api/core/splitter/text_splitter.py:803 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:803: DeprecationWarning: invalid escape sequence '\*' "\n\*\*\*+\n", api/core/splitter/text_splitter.py:816 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:816: DeprecationWarning: invalid escape sequence '\c' "\n\\\chapter{", api/core/splitter/text_splitter.py:817 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:817: DeprecationWarning: invalid escape sequence '\s' "\n\\\section{", api/core/splitter/text_splitter.py:818 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:818: DeprecationWarning: invalid escape sequence '\s' "\n\\\subsection{", api/core/splitter/text_splitter.py:819 /home/runner/work/dify/dify/api/core/splitter/text_splitter.py:819: DeprecationWarning: invalid escape sequence '\s' "\n\\\subsubsection{", ``` ## Type of Change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # How Has This Been Tested? - [x] pass the `test_text_splitter` tests # Suggested Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:23:27 -05:00
yindo closed this issue 2026-02-21 20:23:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24670
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?