langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #5005] 🔧 fix docker-compose ssrf_proxy service WARNING: You should probably remove '::/0' from the ACL named 'all' #24734

New Issue
Closed
opened 2026-02-21 20:23:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:23:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/5005

State: closed
Merged: Yes

🔧 fix(squid.conf): change ACL name from 'all' to 'src_all' to avoid conflict

Renamed the ACL name from 'all' to 'src_all'. This avoids conflicts with predefined keywords. It fixed "WARNING: You should probably remove '::/0' from the ACL named 'all'"

Description

The ssrf_proxy serivce in docker-compose.yaml occrured waring.

ssrf_proxy-1  | 2024/06/06 16:47:51| Processing Configuration File: /etc/squid/squid.conf (depth 0)
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: (B) '::/0' is a subnetwork of (A) '::/0'
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: because of this '::/0' is ignored to keep splay tree searching predictable
ssrf_proxy-1  | 2024/06/06 16:47:51| WARNING: You should probably remove '::/0' from the ACL named 'all'
ssrf_proxy-1  | 2024/06/06 16:47:51| Created PID file (/run/squid.pid)

This is because, ACL 'all' is predefined in squid.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I restarted and confirmed that the warning was gone.

$ docker compose up ssrf_proxy 
Attaching to ssrf_proxy-1
ssrf_proxy-1  | 2024/06/06 16:50:12| Processing Configuration File: /etc/squid/squid.conf (depth 0)
ssrf_proxy-1  | 2024/06/06 16:50:12| Created PID file (/run/squid.pid)
ssrf_proxy-1  | 2024/06/06 16:50:12| Set Current Directory to /var/spool/squid
ssrf_proxy-1  | 2024/06/06 16:50:12| Creating missing swap directories

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/5005 **State:** closed **Merged:** Yes --- 🔧 fix(squid.conf): change ACL name from 'all' to 'src_all' to avoid conflict Renamed the ACL name from 'all' to 'src_all'. This avoids conflicts with predefined keywords. It fixed "WARNING: You should probably remove '::/0' from the ACL named 'all'" # Description The ssrf_proxy serivce in docker-compose.yaml occrured waring. ``` ssrf_proxy-1 | 2024/06/06 16:47:51| Processing Configuration File: /etc/squid/squid.conf (depth 0) ssrf_proxy-1 | 2024/06/06 16:47:51| WARNING: (B) '::/0' is a subnetwork of (A) '::/0' ssrf_proxy-1 | 2024/06/06 16:47:51| WARNING: because of this '::/0' is ignored to keep splay tree searching predictable ssrf_proxy-1 | 2024/06/06 16:47:51| WARNING: You should probably remove '::/0' from the ACL named 'all' ssrf_proxy-1 | 2024/06/06 16:47:51| Created PID file (/run/squid.pid) ``` This is because, ACL 'all' is predefined in squid. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? I restarted and confirmed that the warning was gone. ``` shell $ docker compose up ssrf_proxy Attaching to ssrf_proxy-1 ssrf_proxy-1 | 2024/06/06 16:50:12| Processing Configuration File: /etc/squid/squid.conf (depth 0) ssrf_proxy-1 | 2024/06/06 16:50:12| Created PID file (/run/squid.pid) ssrf_proxy-1 | 2024/06/06 16:50:12| Set Current Directory to /var/spool/squid ssrf_proxy-1 | 2024/06/06 16:50:12| Creating missing swap directories ``` # Suggested Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:23:34 -05:00
yindo closed this issue 2026-02-21 20:23:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?