langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-28 05:20:07 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #5023] Fix language setting not success #24738

New Issue
Closed
opened 2026-02-21 20:23:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:23:35 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/5023

State: closed
Merged: Yes

Description

I can reproduce the issue with my local code, but changing the language works fine on cloud.dify.ai. However, I believe there are still some areas for improvement.

On the language settings page, when changing the language, a request is posted to update the user profile. Before this request, the 'setLocaleOnClient' function is called, which reloads the page. In my local environment, the request to update the user profile does not get sent correctly.

As a result, the local context locale and the user profile in the database become inconsistent. For example, the local context locale is set to 'Chinese', but the user profile in the database remains 'English', this discrepancy causes issues such as the Explore page displaying the app list in English while other parts of the interface are in Chinese.

Additionally, since changing the language reloads the page, there is no need to call 'mutateUserProfile'.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/5023 **State:** closed **Merged:** Yes --- # Description I can reproduce the issue with my local code, but changing the language works fine on cloud.dify.ai. However, I believe there are still some areas for improvement. On the language settings page, when changing the language, a request is posted to update the user profile. Before this request, the 'setLocaleOnClient' function is called, which reloads the page. In my local environment, the request to update the user profile does not get sent correctly. As a result, the local context locale and the user profile in the database become inconsistent. For example, the local context locale is set to 'Chinese', but the user profile in the database remains 'English', this discrepancy causes issues such as the Explore page displaying the app list in English while other parts of the interface are in Chinese. Additionally, since changing the language reloads the page, there is no need to call 'mutateUserProfile'. ## Type of Change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] TODO # Suggested Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:23:35 -05:00
yindo closed this issue 2026-02-21 20:23:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?