langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #5258] fix: respect the interface language specified by the user on the activation success screen #24844

New Issue
Closed
opened 2026-02-21 20:23:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:23:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/5258

State: closed
Merged: Yes

Description

This PR changes activation success screen to display message in the user-provided interface language.

The implementation of fallback to zh-Hans if the specified language is not in en-US seems to have been introduced in #942.
At the time of #942, it seems that the only interface languages were zh or en, so that implementation was appropriate.

Now that a wide variety of languages are supported, it is more appropriate to simply use the language specified by the user instead of falling back to zh.

Fixes #5256

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Activate new user with non-en nor zh language. Ensure the success screen is displayed in the selected language instead of zh

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/5258 **State:** closed **Merged:** Yes --- # Description This PR changes activation success screen to display message in the user-provided interface language. The implementation of fallback to `zh-Hans` if the specified language is not in `en-US` seems to have been introduced in #942. At the time of #942, it seems that the only interface languages were `zh` or `en`, so that implementation was appropriate. Now that a wide variety of languages are supported, it is more appropriate to simply use the language specified by the user instead of falling back to `zh`. Fixes #5256 ## Type of Change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] Activate new user with non-`en` nor `zh` language. Ensure the success screen is displayed in the selected language instead of `zh` # Suggested Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:23:47 -05:00
yindo closed this issue 2026-02-21 20:23:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?