langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #5606] fix: DuckDuckGo image search tool error #24993

New Issue
Closed
opened 2026-02-21 20:24:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:24:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/5606

State: closed
Merged: Yes

Description

  1. Fixes https://github.com/langgenius/dify/issues/5244. As the doc described, we should pass IDs instead of Model objects to avoid DetachedInstanceError.
  2. Now the image search results will not be downloaded. For agent mode, the images display well. For workflow mode, I add a remote_url field in the files response to avoid affect others.

1719371661878

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

I test it locally.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes
**Original Pull Request:** https://github.com/langgenius/dify/pull/5606 **State:** closed **Merged:** Yes --- # Description 1. Fixes https://github.com/langgenius/dify/issues/5244. As the [doc](https://github.com/langgenius/dify/blob/main/api/core/app/apps/README.md) described, we should pass IDs instead of Model objects to avoid DetachedInstanceError. 2. Now the image search results will not be downloaded. For agent mode, the images display well. For workflow mode, I add a `remote_url` field in the files response to avoid affect others. ![1719371661878](https://github.com/langgenius/dify/assets/25834719/b6e4b60c-9322-48bf-a540-a9ffe25d9f21) ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement # How Has This Been Tested? I test it locally. # Suggested Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods - [ ] `optional` I have made corresponding changes to the documentation - [ ] `optional` I have added tests that prove my fix is effective or that my feature works - [ ] `optional` New and existing unit tests pass locally with my changes
yindo added the pull-request label 2026-02-21 20:24:04 -05:00
yindo closed this issue 2026-02-21 20:24:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#24993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?