langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #6427] Fix ScrapeTool parameter validation errors #25273

New Issue
Closed
opened 2026-02-21 20:24:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:24:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/6427

State: closed
Merged: No

Changed placeholders to I18nObject instances to pass validation checks.

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix validation error for ScrapeTool parameters

The previous implementation contained invalid placeholders for the
ScrapeTool parameters, causing validation errors during runtime.
This was due to the placeholders not being instances of I18nObject.

To resolve this, I've updated the placeholders to use I18nObject instances,
providing correct translations for 'zh_Hans', 'pt_BR', and 'en_US'.
This ensures that the tool's parameters are now properly validated.

Related issue: #123
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency upgrade
**Original Pull Request:** https://github.com/langgenius/dify/pull/6427 **State:** closed **Merged:** No --- Changed placeholders to I18nObject instances to pass validation checks. # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] Please open an issue before creating a PR or link to an existing issue - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description Fix validation error for ScrapeTool parameters The previous implementation contained invalid placeholders for the ScrapeTool parameters, causing validation errors during runtime. This was due to the placeholders not being instances of I18nObject. To resolve this, I've updated the placeholders to use I18nObject instances, providing correct translations for 'zh_Hans', 'pt_BR', and 'en_US'. This ensures that the tool's parameters are now properly validated. Related issue: #123 Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: `Fixes #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. Fixes ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Dependency upgrade
yindo added the pull-request label 2026-02-21 20:24:37 -05:00
yindo closed this issue 2026-02-21 20:24:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#25273
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?