langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #6451] fix: next suggest question logic problem #25285

New Issue
Closed
opened 2026-02-21 20:24:38 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:24:38 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/6451

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

In the original logic, if the chat history exceeded the 3000 tokens limit, it would be trimmed. However, when the last response from the LLM exceeded 3000 tokens, the entire chat history would be truncated, resulting in an empty history. This would cause the next suggest questions to generate based on an empty history, which would likely produce non-relevant English suggestions. The PR enhanced the prompt for generating next suggest questions to ensure that they align with the user's language and modified the logic for trimming chat history to keep at least the last round of responses, thereby fixing the issue of generating suggest questions that are not relevant to the user's topic.
Fixes #6231

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • 修复问题后，next suggest questions不会因为上一轮对话超过3000个token就显示无关的英文建议问题
  • 修复问题后，next suggest questions会跟随聊天用户的query语种生成对应语种的问题
**Original Pull Request:** https://github.com/langgenius/dify/pull/6451 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description In the original logic, if the chat history exceeded the 3000 tokens limit, it would be trimmed. However, when the last response from the LLM exceeded 3000 tokens, the entire chat history would be truncated, resulting in an empty history. This would cause the next suggest questions to generate based on an empty history, which would likely produce non-relevant English suggestions. The PR enhanced the prompt for generating next suggest questions to ensure that they align with the user's language and modified the logic for trimming chat history to keep at least the last round of responses, thereby fixing the issue of generating suggest questions that are not relevant to the user's topic. Fixes #6231 ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] 修复问题后，next suggest questions不会因为上一轮对话超过3000个token就显示无关的英文建议问题 - [x] 修复问题后，next suggest questions会跟随聊天用户的query语种生成对应语种的问题
yindo added the pull-request label 2026-02-21 20:24:38 -05:00
yindo closed this issue 2026-02-21 20:24:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#25285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?