langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #6934] Fixed a bug where permission was clearly displaye… #25502

New Issue
Closed
opened 2026-02-21 20:25:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:25:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/6934

State: closed
Merged: Yes

…d when basic knowledge base information was modified on the home page

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

The issue has been fixed by ensuring that the permissions are correctly managed when the knowledge base settings are updated.

if data.get('partial_member_list') and data.get('permission') == 'partial_members':
DatasetPermissionService.update_partial_member_list(
tenant_id, dataset_id_str, data.get('partial_member_list')
)
elif data.get('permission') == 'only_me' or data.get('permission') == 'all_team_members':
DatasetPermissionService.clear_partial_member_list(dataset_id_str)

​- When partial_member_list is provided and permission is set to partial_members, the list is updated accordingly.

  • When permission is set to only_me or all_team_members, the partial_member_list is cleared, ensuring the permissions are correctly handled.
    ​This change ensures that permissions are preserved or appropriately cleared based on the visibility settings, preventing the knowledge base from becoming inaccessible.

​---
​Please review and let me know if any further adjustments are needed.

Fixes #6933

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: Manually tested the homepage to ensure the knowledge base information updates correctly.
  • Test B: Ran the full test suite to ensure no other functionalities are affected.
**Original Pull Request:** https://github.com/langgenius/dify/pull/6934 **State:** closed **Merged:** Yes --- …d when basic knowledge base information was modified on the home page # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description The issue has been fixed by ensuring that the permissions are correctly managed when the knowledge base settings are updated. ``` if data.get('partial_member_list') and data.get('permission') == 'partial_members': DatasetPermissionService.update_partial_member_list( tenant_id, dataset_id_str, data.get('partial_member_list') ) elif data.get('permission') == 'only_me' or data.get('permission') == 'all_team_members': DatasetPermissionService.clear_partial_member_list(dataset_id_str) ``` ​- **When `partial_member_list` is provided and permission is set to `partial_members`,** the list is updated accordingly. - **When permission is set to `only_me` or `all_team_members`,** the `partial_member_list` is cleared, ensuring the permissions are correctly handled. ​This change ensures that permissions are preserved or appropriately cleared based on the visibility settings, preventing the knowledge base from becoming inaccessible. ​--- ​Please review and let me know if any further adjustments are needed. Fixes #6933 ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [[Dify Document](https://github.com/langgenius/dify-docs)](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] Test A: Manually tested the homepage to ensure the knowledge base information updates correctly. - [x] Test B: Ran the full test suite to ensure no other functionalities are affected.
yindo added the pull-request label 2026-02-21 20:25:03 -05:00
yindo closed this issue 2026-02-21 20:25:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#25502
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?