langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #7124] Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value. #25574

New Issue
Closed
opened 2026-02-21 20:25:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:25:13 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/7124

State: closed
Merged: Yes

Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value.

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR updates the Japanese translation for the "embeddedSpend" field in the dataset-documents.ts file. The translation has been changed from "埋め込み時間" to "埋め込みコスト" to more accurately reflect the meaning of "Embedded spend".

This change is related to the issue of i18n translations not being reflected in the Docker environment, which is being tracked separately in issue #7123. While this PR addresses the translation update itself, the visibility of this change in the Docker environment is still under investigation.

Fixes #(issue number for the translation update, if one exists)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

To verify this change:

  1. Navigate to the web/i18n/ja-JP/dataset-documents.ts file.
  2. Confirm that the "embeddedSpend" field is now translated as "埋め込みコスト".
  3. Run the following commands to build the project: 
    cd /path/to/dify/
npm ci
cd web/
npm ci
npm run build
  4. Check the built files to ensure the change is included: 
    cd /path/to/dify/web/.next/server
grep -r "埋め込みコスト" .
  5. Launch the application and navigate to the relevant UI section to visually confirm the change.

Note: As mentioned in issue #7123, there may be discrepancies between the built files and the Docker environment. However, since npm build succeeds and the updated string can be found in /path/to/dify/web/.next/server, I believe this PR sufficiently addresses the .ts file syntax update. The Docker-related discrepancy would be investigated separately and should not block this translation update.

**Original Pull Request:** https://github.com/langgenius/dify/pull/7124 **State:** closed **Merged:** Yes --- Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value. # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description This PR updates the Japanese translation for the "embeddedSpend" field in the dataset-documents.ts file. The translation has been changed from "埋め込み時間" to "埋め込みコスト" to more accurately reflect the meaning of "Embedded spend". This change is related to the issue of i18n translations not being reflected in the Docker environment, which is being tracked separately in issue #7123. While this PR addresses the translation update itself, the visibility of this change in the Docker environment is still under investigation. Fixes #(issue number for the translation update, if one exists) ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions To verify this change: 1. Navigate to the `web/i18n/ja-JP/dataset-documents.ts` file. 2. Confirm that the "embeddedSpend" field is now translated as "埋め込みコスト". 3. Run the following commands to build the project: ``` cd /path/to/dify/ npm ci cd web/ npm ci npm run build ``` 4. Check the built files to ensure the change is included: ``` cd /path/to/dify/web/.next/server grep -r "埋め込みコスト" . ``` 5. Launch the application and navigate to the relevant UI section to visually confirm the change. Note: As mentioned in issue #7123, there may be discrepancies between the built files and the Docker environment. However, since `npm build` succeeds and the updated string can be found in `/path/to/dify/web/.next/server`, I believe this PR sufficiently addresses the `.ts` file syntax update. The Docker-related discrepancy would be investigated separately and should not block this translation update.
yindo added the pull-request label 2026-02-21 20:25:13 -05:00
yindo closed this issue 2026-02-21 20:25:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#25574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?