langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #7630] add：save_model_credentials error log #25776

New Issue
Closed
opened 2026-02-21 20:25:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:25:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/7630

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR enhances the error logging for the save_model_credentials method in the ModelProviderModelApi class. By adding a detailed stack trace log when a CredentialsValidateFailedError occurs, we improve our ability to debug and quickly identify the root cause of credential validation failures, especially in complex model validation scenarios.

This change does not alter the existing functionality but significantly improves observability, which is crucial for troubleshooting in production environments.

Fixes #[Issue number] (Please replace with the actual issue number if one exists)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

To verify this change:

  • Intentionally trigger a CredentialsValidateFailedError in the save_model_credentials method
  • Check the logs to ensure the full stack trace is present
  • Run existing unit tests to confirm no regression
**Original Pull Request:** https://github.com/langgenius/dify/pull/7630 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description This PR enhances the error logging for the `save_model_credentials` method in the `ModelProviderModelApi` class. By adding a detailed stack trace log when a `CredentialsValidateFailedError` occurs, we improve our ability to debug and quickly identify the root cause of credential validation failures, especially in complex model validation scenarios. This change does not alter the existing functionality but significantly improves observability, which is crucial for troubleshooting in production environments. Fixes #[Issue number] (Please replace with the actual issue number if one exists) ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions To verify this change: - [ ] Intentionally trigger a `CredentialsValidateFailedError` in the `save_model_credentials` method - [ ] Check the logs to ensure the full stack trace is present - [ ] Run existing unit tests to confirm no regression
yindo added the pull-request label 2026-02-21 20:25:40 -05:00
yindo closed this issue 2026-02-21 20:25:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#25776
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?