langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #8681] chore: Optimize I18nObject class for better performance and readability #26128

New Issue
Closed
opened 2026-02-21 20:36:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:36:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/8681

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Reorder fields to put required 'en_US' first
  • Use Pydantic's Field for optional fields with default values
  • Remove unnecessary if statements in init
  • Update type hints for clarity

Type of Change

  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
**Original Pull Request:** https://github.com/langgenius/dify/pull/8681 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description - Reorder fields to put required 'en_US' first - Use Pydantic's Field for optional fields with default values - Remove unnecessary if statements in __init__ - Update type hints for clarity ## Type of Change - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
yindo added the pull-request label 2026-02-21 20:36:25 -05:00
yindo closed this issue 2026-02-21 20:36:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26128
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?