langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #9148] fix: response_format of model_parameters will not be removed #26315

New Issue
Closed
opened 2026-02-21 20:39:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:39:20 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/9148

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes https://github.com/langgenius/dify/issues/8451

thanks for @tuoxiansp debug

the code here will remove the response_format of model_parameters . seems in earlier days, we use a custom prompt to let the user get a JSON or XML response of LLM. But nowadays, the response_format also will be used in lots of LLM's request parameters, we should not remove it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

use debug panel to check the params send to Azure. I don't have a key, not check the response result.

  • Test A
  • Test B
**Original Pull Request:** https://github.com/langgenius/dify/pull/9148 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description Fixes https://github.com/langgenius/dify/issues/8451 thanks for @tuoxiansp debug the code [here](https://github.com/langgenius/dify/blob/b279d1904085d0265c4b0a0ef5843bc11b22c837/api/core/model_runtime/model_providers/__base/large_language_model.py#L205) will remove the `response_format` of `model_parameters `. seems in earlier days, we use a custom prompt to let the user get a JSON or XML response of LLM. But nowadays, the `response_format` also will be used in lots of LLM's request parameters, we should not remove it. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions use debug panel to check the params send to Azure. I don't have a key, not check the response result. - [ ] Test A - [ ] Test B
yindo added the pull-request label 2026-02-21 20:39:20 -05:00
yindo closed this issue 2026-02-21 20:39:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26315
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?