langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #9469] controller test #26434

New Issue
Closed
opened 2026-02-21 20:39:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:39:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/9469

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

As said in this request https://github.com/langgenius/dify/issues/9468 this is an example of IT.
I had to improve the Factory Pattern of the APP splitting the code in 2 classes one the factory and the other the app entry point (as described here here https://medium.com/@ferrohardian/application-factory-pattern-starting-your-flask-project-e17dd2f12013). Without this improviment the test executes two times the create_app method.

Fixes https://github.com/langgenius/dify/issues/9468

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • End to end test: execute the hole system to verify that the split of the app.py doesn't break anything
  • Integration test: execute the integration test created with debug from vscode and see that the app stops in the breaking point in the controller and returns 200.
**Original Pull Request:** https://github.com/langgenius/dify/pull/9469 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [X] Please open an issue before creating a PR or link to an existing issue - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description As said in this request https://github.com/langgenius/dify/issues/9468 this is an example of IT. I had to improve the Factory Pattern of the APP splitting the code in 2 classes one the factory and the other the app entry point (as described here here https://medium.com/@ferrohardian/application-factory-pattern-starting-your-flask-project-e17dd2f12013). Without this improviment the test executes two times the _create_app_ method. Fixes https://github.com/langgenius/dify/issues/9468 ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [X] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [X] End to end test: execute the hole system to verify that the split of the _app.py_ doesn't break anything - [X] Integration test: execute the integration test created with debug from vscode and see that the app stops in the breaking point in the controller and returns 200.
yindo added the pull-request label 2026-02-21 20:39:34 -05:00
yindo closed this issue 2026-02-21 20:39:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?