langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #9672] fix: revert ref usage in handleFormChange to fix IME input issues #26522

New Issue
Closed
opened 2026-02-21 20:39:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:39:45 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/9672

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR partially reverts recent following two changes to the handleFormChange function on #9526 to fix issues with IME input, where typing would result in duplicated characters or premature confirmation of incomplete input.

In #9526, the handleFormChange function was updated:

  • useCallback was removed
  • ref (newConversationInputsRef.current) was used instead of state

After this change, IME input (e.g., for Japanese) started to behave incorrectly, with input duplication and issues during conversion.

Fixes #9671
Fixes https://github.com/langgenius/dify/issues/9663

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • The variables of the published app can be input, and available in the chatbot
  • The variables of the embedded app can be input, and available in the chatbot
**Original Pull Request:** https://github.com/langgenius/dify/pull/9672 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description This PR partially reverts recent following two changes to the `handleFormChange` function on #9526 to fix issues with IME input, where typing would result in duplicated characters or premature confirmation of incomplete input. - https://github.com/langgenius/dify/commit/7a1d6fe50984cb9b59a7f3275ace2eed49c98753#diff-92c707357704c4a775717f83fd603cfd38b31e9728714a26c33fc9451ab19e8aL16-L21 - https://github.com/langgenius/dify/commit/7a1d6fe50984cb9b59a7f3275ace2eed49c98753#diff-a77ab2b9e1dfac46a474c7abe9ee62abc94270b2f958d7bb719166c19bf1b75bL16-L21 In #9526, the `handleFormChange` function was updated: - useCallback was removed - ref (newConversationInputsRef.current) was used instead of state After this change, IME input (e.g., for Japanese) started to behave incorrectly, with input duplication and issues during conversion. Fixes #9671 Fixes https://github.com/langgenius/dify/issues/9663 ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] The variables of the published app can be input, and available in the chatbot - [x] The variables of the embedded app can be input, and available in the chatbot
yindo added the pull-request label 2026-02-21 20:39:45 -05:00
yindo closed this issue 2026-02-21 20:39:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?