langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #9906] Feat/add-remote-file-upload-api #26602

New Issue
Closed
opened 2026-02-21 20:39:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:39:54 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/9906

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue #9878
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. File Upload Refactoring:

    • Refactored file upload logic in multiple controllers to use a new FileService.upload_file method signature.
    • The new method takes separate parameters for filename, content, mimetype, user, and source instead of a FileStorage object.
    • Added checks for empty filenames and improved error handling.

  2. Remote File Handling:

    • Implemented a RemoteFileUploadApi class for handling remote file operations.
    • Added functionality to download remote files, guess MIME types and generate filenames when needed.

  3. Error Handling:

    • Introduced a new FilenameNotExistsError for cases where a file is uploaded without a filename.

  4. Controller Restructuring:

    • Moved file-related controllers from web/__init__.py to separate web/files.py and web/remote_files.py files.
    • Updated imports and API resource registrations accordingly.

  5. Setup Required Decorator:

    • Moved the setup_required decorator from setup.py to wraps.py.
    • Updated all imports of setup_required to use the new location.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
**Original Pull Request:** https://github.com/langgenius/dify/pull/9906 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue #9878 - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description 1. File Upload Refactoring: - Refactored file upload logic in multiple controllers to use a new `FileService.upload_file` method signature. - The new method takes separate parameters for filename, content, mimetype, user, and source instead of a FileStorage object. - Added checks for empty filenames and improved error handling. 2. Remote File Handling: - Implemented a `RemoteFileUploadApi` class for handling remote file operations. - Added functionality to download remote files, guess MIME types and generate filenames when needed. 3. Error Handling: - Introduced a new `FilenameNotExistsError` for cases where a file is uploaded without a filename. 4. Controller Restructuring: - Moved file-related controllers from `web/__init__.py` to separate `web/files.py` and `web/remote_files.py` files. - Updated imports and API resource registrations accordingly. 5. Setup Required Decorator: - Moved the `setup_required` decorator from `setup.py` to `wraps.py`. - Updated all imports of `setup_required` to use the new location. Fixes ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Test A - [ ] Test B
yindo added the pull-request label 2026-02-21 20:39:54 -05:00
yindo closed this issue 2026-02-21 20:39:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?