langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #10185] Ensure consistent float type for cached embedding return values #26716

New Issue
Closed
opened 2026-02-21 20:40:07 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:40:07 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/10185

State: closed
Merged: Yes

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This PR ensures that the return values of embeddings retrieved from the cache are consistently in float type. This change prevents potential issues caused by type mismatches (float vs float64) during serialization, especially when using Chroma as the vector database.

Fixes #7213

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

  • Test
    • Set up Chroma as the vector database
    • Run a Retrieval Testing
      • Results are retrieved successfully.
    • Run the same search again
      • Before Fix: Prior to this fix, running the search twice would result in an error: Type is not JSON serializable: numpy.float64.
      • After Fix: After applying this fix, the same search should succeed without errors, and the results should be retrieved consistently.
**Original Pull Request:** https://github.com/langgenius/dify/pull/10185 **State:** closed **Merged:** Yes --- # Checklist: > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] Please open an issue before creating a PR or link to an existing issue - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods # Description This PR ensures that the return values of embeddings retrieved from the cache are consistently in float type. This change prevents potential issues caused by type mismatches (`float` vs `float64`) during serialization, especially when using Chroma as the vector database. Fixes #7213 ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement - [ ] Dependency upgrade # Testing Instructions - Test - Set up Chroma as the vector database - Run a Retrieval Testing - Results are retrieved successfully. - Run the same search again - Before Fix: Prior to this fix, running the search twice would result in an error: `Type is not JSON serializable: numpy.float64`. - After Fix: After applying this fix, the same search should succeed without errors, and the results should be retrieved consistently.
yindo added the pull-request label 2026-02-21 20:40:07 -05:00
yindo closed this issue 2026-02-21 20:40:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?