langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #10907] fix: handle redis authentication for healthcheck command #26990

New Issue
Closed
opened 2026-02-21 20:40:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:40:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/10907

State: closed
Merged: Yes

Summary

Fixes #10898

This PR includes the following changes:

Brief explanation: The env_file parameter is used to pass environment variables to containers, while variables in the docker compose yaml file like ${REDIS_PASSWORD:-difyai123456} require environment variables during docker-compose command execution. Since the middleware env file in the documentation won't be automatically loaded as a .env file, the --env-file flag is necessary for docker-compose commands to properly substitute default values with the complete environment variables.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/10907 **State:** closed **Merged:** Yes --- # Summary Fixes #10898 This PR includes the following changes: * Resolved the issue in #10898 by adding the `REDISCLI_AUTH` parameter * Aligned the separator position in `env.example` with the overall format * And one update with Readme: Modified `docker-compose` command parameters to ensure proper variable substitution, according to: * [Environment variables precedence in Docker Compose](https://docs.docker.com/compose/how-tos/environment-variables/envvars-precedence/) * [Substitute with --env-file](https://docs.docker.com/compose/how-tos/environment-variables/variable-interpolation/#substitute-with---env-file) Brief explanation: The `env_file` parameter is used to pass environment variables to containers, while variables in the docker compose yaml file like `${REDIS_PASSWORD:-difyai123456}` require environment variables during `docker-compose` command execution. Since the middleware env file in the documentation won't be automatically loaded as a `.env` file, the `--env-file` flag is necessary for docker-compose commands to properly substitute default values with the complete environment variables. > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots <table> <tr> <td>Before: </td> <td>After: </td> </tr> <tr> <td>...</td> <td>...</td> </tr> </table> # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:40:39 -05:00
yindo closed this issue 2026-02-21 20:40:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?