langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #10921] feat: mypy for all type check #26991

New Issue
Closed
opened 2026-02-21 20:40:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:40:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/10921

State: closed
Merged: Yes

Summary

This maybe a huge Pull Request, the main goal is to make all the mypy type check passed to fix the potential bugs
So its still WIP and will be draft. and try to close https://github.com/langgenius/dify/issues/10928

the first steps had beed done. -> let mypy work in api folder.
And we fixed some of them,

you can check by

  • gh pr checkout 10921

  • when found small bug fix in main branch first

  • install mypy

  • cd api && mypy .

  • make it work for mypy

  • add ci for it

  • always merge main for the latest code

  • fixed them folder by folder, maybe type by type

for now after this commit it still has 4261 errors

some details update here:

image

@laipz8200 @crazywoola

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/10921 **State:** closed **Merged:** Yes --- # Summary This maybe a huge Pull Request, the main goal is to make all the `mypy` type check passed to fix the potential bugs So its still WIP and will be draft. and try to close https://github.com/langgenius/dify/issues/10928 the first steps had beed done. -> let `mypy` work in `api` folder. And we fixed some of them, you can check by - gh pr checkout 10921 - when found small bug fix in main branch first - install mypy - cd api && mypy . - [x] make it work for mypy - [x] add ci for it - [x] always merge main for the latest code - [x] fixed them folder by folder, maybe type by type for now after this commit it still has 4261 errors some details update here: - https://github.com/pallets-eco/flask-sqlalchemy/issues/1327 ![image](https://github.com/user-attachments/assets/88ed3cd1-15a2-41f0-8a0d-a4b540b9ec91) @laipz8200 @crazywoola > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots <table> <tr> <td>Before: </td> <td>After: </td> </tr> <tr> <td>...</td> <td>...</td> </tr> </table> # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:40:39 -05:00
yindo closed this issue 2026-02-21 20:40:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#26991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?