langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #11445] fix: unit tests env will need clear too #27224

New Issue
Closed
opened 2026-02-21 20:41:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:06 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/11445

State: closed
Merged: Yes

Summary

if we have dify env file .env the unit tests will failed too, because the .env timeout is 600 and the tests env is 60
like


example_env_file = '/private/var/folders/c3/51t_3cqj7bx98dq1ptyy0v700000gn/T/pytest-of-hyi/pytest-28/test_dify_config0/.env'

    def test_dify_config(example_env_file):
        # load dotenv file with pydantic-settings
        config = DifyConfig(_env_file=example_env_file)
    
        # constant values
        assert config.COMMIT_SHA == ""
    
        # default values
        assert config.EDITION == "SELF_HOSTED"
        assert config.API_COMPRESSION_ENABLED is False
        assert config.SENTRY_TRACES_SAMPLE_RATE == 1.0
    
        # annotated field with default value
>       assert config.HTTP_REQUEST_MAX_READ_TIMEOUT == 60
E       AssertionError: assert 600 == 60
E        +  where 600 = DifyConfig(ENTERPRISE_ENABLED=False, CAN_REPLACE_LOGO=False, SENTRY_DSN='', SENTRY_TRACES_SAMPLE_RATE=1.0, SENTRY_PROF..., CONSOLE_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*'], WEB_API_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*']).HTTP_REQUEST_MAX_READ_TIMEOUT

/Users/hyi/prs/dify/api/tests/unit_tests/configs/test_dify_config.py:53: AssertionError

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/11445 **State:** closed **Merged:** Yes --- # Summary if we have dify env file `.env` the unit tests will failed too, because the .env timeout is 600 and the tests env is 60 like ``` example_env_file = '/private/var/folders/c3/51t_3cqj7bx98dq1ptyy0v700000gn/T/pytest-of-hyi/pytest-28/test_dify_config0/.env' def test_dify_config(example_env_file): # load dotenv file with pydantic-settings config = DifyConfig(_env_file=example_env_file) # constant values assert config.COMMIT_SHA == "" # default values assert config.EDITION == "SELF_HOSTED" assert config.API_COMPRESSION_ENABLED is False assert config.SENTRY_TRACES_SAMPLE_RATE == 1.0 # annotated field with default value > assert config.HTTP_REQUEST_MAX_READ_TIMEOUT == 60 E AssertionError: assert 600 == 60 E + where 600 = DifyConfig(ENTERPRISE_ENABLED=False, CAN_REPLACE_LOGO=False, SENTRY_DSN='', SENTRY_TRACES_SAMPLE_RATE=1.0, SENTRY_PROF..., CONSOLE_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*'], WEB_API_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*']).HTTP_REQUEST_MAX_READ_TIMEOUT /Users/hyi/prs/dify/api/tests/unit_tests/configs/test_dify_config.py:53: AssertionError ``` > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:06 -05:00
yindo closed this issue 2026-02-21 20:41:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?