langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #11700] fix: memory leak by pypdfium2 close(maybe) #11510 #27330

New Issue
Closed
opened 2026-02-21 20:41:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/11700

State: closed
Merged: Yes

Summary

This patch fix a memory leak by updating the pypdfium2 version to latest. close #11510

how to trace the memory leak:

follow the article: https://pythonspeed.com/articles/python-server-memory-leaks/

  1. using filprofiler
  2. run the program python -m filprofiler run app.py
  3. another program run times python -m pytest api/tests/integration_tests/workflow

the memory profile show almost all memory cost from pypdfium2

image

search the net found these:
https://github.com/facebookresearch/nougat/issues/110
https://forum.patagames.com/posts/t805-Memory-Leak-in-PDFDocument-Load-when-Pdfium-FPDF-LoadCustomDocument-returns-an-IntPtr-Zero

try to update the pypdfium2 version to latest

https://pyoven.org/package/pypdfium2?tab=versions

than do the steps again
new memory profile looks normal

image

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/11700 **State:** closed **Merged:** Yes --- # Summary This patch fix a memory leak by updating the pypdfium2 version to latest. close #11510 how to trace the memory leak: follow the article: https://pythonspeed.com/articles/python-server-memory-leaks/ 1. using filprofiler 2. run the program `python -m filprofiler run app.py` 3. another program run times `python -m pytest api/tests/integration_tests/workflow` the memory profile show almost all memory cost from pypdfium2 ![image](https://github.com/user-attachments/assets/eb67539e-0982-4bce-a992-5061a0c014ae) search the net found these: https://github.com/facebookresearch/nougat/issues/110 https://forum.patagames.com/posts/t805-Memory-Leak-in-PDFDocument-Load-when-Pdfium-FPDF-LoadCustomDocument-returns-an-IntPtr-Zero try to update the pypdfium2 version to latest https://pyoven.org/package/pypdfium2?tab=versions than do the steps again new memory profile looks normal ![image](https://github.com/user-attachments/assets/8c4b8044-6ec3-43ec-a10c-a0ee3ceba25a) > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:18 -05:00
yindo closed this issue 2026-02-21 20:41:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?