langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-25 13:36:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #11859] Fix comfyui tool https #27385

New Issue
Closed
opened 2026-02-21 20:41:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/11859

State: closed
Merged: Yes

@crazywoola Sorry, I missed one. When comfyui generates pictures, you also need to use websocket connection~

Summary

Fixes #11822
Because not all comfyui are deployed with dify, this part of the code currently has a check for "if comfyui is an https website, it cannot be successfully connected", so the judgment of the http protocol is added. If the comfyui website protocol is http, the websocket connection string is ws://, if the comfyui website protocol is https, then the websocket connection string is wss://.

Tip

Fixes #11822

Screenshots

Before:
This is an error before it is fixed. Regardless of the comfyui website protocol, ws:// will be used for websocket connectivity testing.
image

After：
This is after the repair, select the websocket connection string according to the comfyui website protocol
image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/11859 **State:** closed **Merged:** Yes --- @crazywoola Sorry, I missed one. When comfyui generates pictures, you also need to use websocket connection~ # Summary Fixes #11822 Because not all comfyui are deployed with dify, this part of the code currently has a check for "if comfyui is an https website, it cannot be successfully connected", so the judgment of the http protocol is added. If the comfyui website protocol is http, the websocket connection string is ws://, if the comfyui website protocol is https, then the websocket connection string is wss://. > [!Tip] >Fixes #11822 # Screenshots Before: This is an error before it is fixed. Regardless of the comfyui website protocol, ws:// will be used for websocket connectivity testing. ![image](https://github.com/user-attachments/assets/96d7a865-66d0-4dd1-9398-01c814c7655d) After： This is after the repair, select the websocket connection string according to the comfyui website protocol ![image](https://github.com/user-attachments/assets/6b686b3d-958a-463c-b83f-f15446eaeab6) # Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:25 -05:00
yindo closed this issue 2026-02-21 20:41:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?