langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-24 21:16:24 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #11860] fix: add safe dictionary access for bedrock credentials #27386

New Issue
Closed
opened 2026-02-21 20:41:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/11860

State: closed
Merged: Yes

Summary

This PR enhances error handling as discussed in Issue #11819 by implementing safe dictionary access for AWS credentials. Previously, the code relied on direct dictionary access, which risked KeyError exceptions if aws_region was missing in the provided credentials.

Changes made:

  • Replace direct dictionary access with .get() method for aws_region
  • Add validation check to ensure aws_region is provided
  • Raise InvokeBadRequestError with a clear error message if the required credential is missing

This change makes the code more robust and provides better error handling for missing AWS region configuration.

Checklist

  • This change requires a documentation update
  • I understand that this PR may be closed in case there was no previous discussion or issues
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change
  • I've updated the documentation accordingly
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/11860 **State:** closed **Merged:** Yes --- # Summary This PR enhances error handling as discussed in Issue #11819 by implementing safe dictionary access for AWS credentials. Previously, the code relied on direct dictionary access, which risked KeyError exceptions if aws_region was missing in the provided credentials. Changes made: - Replace direct dictionary access with `.get()` method for aws_region - Add validation check to ensure aws_region is provided - Raise InvokeBadRequestError with a clear error message if the required credential is missing This change makes the code more robust and provides better error handling for missing AWS region configuration. # Checklist - [ ] This change requires a documentation update - [x] I understand that this PR may be closed in case there was no previous discussion or issues - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change - [x] I've updated the documentation accordingly - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:25 -05:00
yindo closed this issue 2026-02-21 20:41:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?