langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-25 13:36:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #11907] fix: dataset search-input compostion can't work in chrome #27406

New Issue
Closed
opened 2026-02-21 20:41:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/11907

State: closed
Merged: Yes

Summary

The search box on the dataset page has two bugs when using Chinese input in chrome browser.

  1. "isComposing" prevents characters from being rendered and makes the input method not work properly.(first gif below)
  2. The onChange event of the input component triggers before the onCompositionEnd event in chrome, causing the search api not to be triggered after the IME confirms the input.(second gif below)

I added an internal value to make sure the input box renders the character being typed in IME properly to fix the first bug, and called the onchange event trigger at the end of onCompositionEnd to fix bug 2

Screenshots

I've added console log logging to keep track of variables when debugging locally
console_log

Before After(fix bug1) After(fix bug1+bug2)
nofix fixed1 fixed2

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/11907 **State:** closed **Merged:** Yes --- # Summary The search box on the dataset page has two bugs when using Chinese input in chrome browser. 1. "isComposing" prevents characters from being rendered and makes the input method not work properly.(first gif below) 2. The onChange event of the input component triggers before the onCompositionEnd event in chrome, causing the search api not to be triggered after the IME confirms the input.(second gif below) I added an internal value to make sure the input box renders the character being typed in IME properly to fix the first bug, and called the onchange event trigger at the end of onCompositionEnd to fix bug 2 # Screenshots I've added console log logging to keep track of variables when debugging locally <img width="920" alt="console_log" src="https://github.com/user-attachments/assets/a3dbc42c-7c8b-411b-8557-c57938c4929a" /> | Before | After(fix bug1) | After(fix bug1+bug2) |--------|-------|-------| | ![nofix](https://github.com/user-attachments/assets/41771303-0567-4b1f-b671-fadc5550dece) | ![fixed1](https://github.com/user-attachments/assets/8903ad73-091e-423c-b03f-08984dea4b7d)| ![fixed2](https://github.com/user-attachments/assets/2381b7b7-459b-4552-b7a1-501acf789dda)| # # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:27 -05:00
yindo closed this issue 2026-02-21 20:41:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27406
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?