langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12046] refactor: replace div with button for better accessibility #27477

New Issue
Closed
opened 2026-02-21 20:41:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:36 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12046

State: closed
Merged: Yes

This pull request includes several changes to the CreateAppCard component in the web/app/(commonLayout)/apps/NewAppCard.tsx file. The main changes involve replacing div elements with button elements for better accessibility and adding a display name to the CreateAppCard component.

Accessibility improvements:

  • Replaced div elements with button elements to ensure proper semantics and accessibility for interactive elements.

Code quality improvements:

  • Added CreateAppCard.displayName to improve debugging and component identification in development tools.
  • Removed an unnecessary eslint-disable-next-line comment that was no longer needed.
**Original Pull Request:** https://github.com/langgenius/dify/pull/12046 **State:** closed **Merged:** Yes --- This pull request includes several changes to the `CreateAppCard` component in the `web/app/(commonLayout)/apps/NewAppCard.tsx` file. The main changes involve replacing `div` elements with `button` elements for better accessibility and adding a display name to the `CreateAppCard` component. Accessibility improvements: * Replaced `div` elements with `button` elements to ensure proper semantics and accessibility for interactive elements. Code quality improvements: * Added `CreateAppCard.displayName` to improve debugging and component identification in development tools. * Removed an unnecessary `eslint-disable-next-line` comment that was no longer needed.
yindo added the pull-request label 2026-02-21 20:41:36 -05:00
yindo closed this issue 2026-02-21 20:41:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?