langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12194] Feat elasticsearch japanese #27549

New Issue
Closed
opened 2026-02-21 20:41:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12194

State: closed
Merged: Yes

Summary

Fixes #12193

This pull request introduces support for a new vector type, ELASTICSEARCH_JA, which includes changes across various files to integrate this new functionality. The most important changes include adding the new vector type to the existing system, implementing the necessary configurations, and modifying the Docker setup to support the new vector type.

Integration of new vector type ELASTICSEARCH_JA:

  • api/controllers/console/datasets/datasets.py: Added VectorType.ELASTICSEARCH_JA to the list of supported vector types.
  • api/core/rag/datasource/vdb/vector_type.py: Added ELASTICSEARCH_JA to the VectorType class.
  • api/core/rag/datasource/vdb/vector_factory.py: Added a case for VectorType.ELASTICSEARCH_JA to return the ElasticSearchJaVectorFactory.
  • api/core/rag/datasource/vdb/elasticsearch/elasticsearch_ja_vector.py: Created a new file to define ElasticSearchJaConfig, ElasticSearchJaVector, and ElasticSearchJaVectorFactory classes, providing the implementation for the new vector type.

Configuration and setup changes:

  • docker/.env.example: Updated the supported values for VECTOR_STORE and modified the ELASTICSEARCH_HOST default value.
  • docker/docker-compose.yaml: Added the elasticsearch-ja profile, updated the elasticsearch service configuration to include the new profile, and added resource limits and entrypoint configurations.
  • docker/elasticsearch/docker-entrypoint.sh: Created a new script to install necessary plugins for elasticsearch-ja and run the original entrypoint script.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12194 **State:** closed **Merged:** Yes --- # Summary Fixes #12193 This pull request introduces support for a new vector type, ELASTICSEARCH_JA, which includes changes across various files to integrate this new functionality. The most important changes include adding the new vector type to the existing system, implementing the necessary configurations, and modifying the Docker setup to support the new vector type. ## Integration of new vector type ELASTICSEARCH_JA: - `api/controllers/console/datasets/datasets.py`: Added `VectorType.ELASTICSEARCH_JA` to the list of supported vector types. - `api/core/rag/datasource/vdb/vector_type.py`: Added `ELASTICSEARCH_JA` to the `VectorType` class. - `api/core/rag/datasource/vdb/vector_factory.py`: Added a case for `VectorType.ELASTICSEARCH_JA` to return the ElasticSearchJaVectorFactory. - `api/core/rag/datasource/vdb/elasticsearch/elasticsearch_ja_vector.py`: Created a new file to define `ElasticSearchJaConfig`, `ElasticSearchJaVector`, and `ElasticSearchJaVectorFactory` classes, providing the implementation for the new vector type. ## Configuration and setup changes: - `docker/.env.example`: Updated the supported values for `VECTOR_STORE` and modified the `ELASTICSEARCH_HOST` default value. - `docker/docker-compose.yaml`: Added the `elasticsearch-ja` profile, updated the elasticsearch service configuration to include the new profile, and added resource limits and `entrypoint` configurations. - `docker/elasticsearch/docker-entrypoint.sh`: Created a new script to install necessary plugins for `elasticsearch-ja` and run the original entrypoint script. # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:44 -05:00
yindo closed this issue 2026-02-21 20:41:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?