langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12188] fix: default value of google storage sa to empty #27551

New Issue
Closed
opened 2026-02-21 20:41:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12188

State: closed
Merged: Yes

Summary

Fixed an error when using Default Service Account in Google Storage.
When using Default Service Account, the environment variable GOOGLE_STORAGE_SERVICE_ACCOUNT_JSON_BASE64 must be an empty string. However, even if an empty string was specified in .env, the default string was specified in docker-compose.yaml. Therefore, the default string was changed to the empty string.

Additional Information.

As an alternative fix, it is possible to change the default to be specified only when undefined, but since the scope of impact is large, this was addressed in this issue.

current style
SOME_VARIABLE: ${SOME_VARIABLE:-default}
alternative style
SOME_VARIABLE: ${SOME_VARIABLE-default}

see https://docs.docker.com/reference/compose-file/interpolation/

Screenshots

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12188 **State:** closed **Merged:** Yes --- # Summary Fixed an error when using Default Service Account in Google Storage. When using Default Service Account, the environment variable GOOGLE_STORAGE_SERVICE_ACCOUNT_JSON_BASE64 must be an empty string. However, even if an empty string was specified in .env, the default string was specified in docker-compose.yaml. Therefore, the default string was changed to the empty string. ## Additional Information. As an alternative fix, it is possible to change the default to be specified only when undefined, but since the scope of impact is large, this was addressed in this issue. current style `SOME_VARIABLE: ${SOME_VARIABLE:-default}` alternative style `SOME_VARIABLE: ${SOME_VARIABLE-default}` see https://docs.docker.com/reference/compose-file/interpolation/ # Screenshots # Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [ ] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:44 -05:00
yindo closed this issue 2026-02-21 20:41:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?