langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12305] Fix code scanning alert no. 111: Incomplete URL substring sanitization #27596

New Issue
Closed
opened 2026-02-21 20:41:49 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:49 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12305

State: closed
Merged: Yes

Fixes https://github.com/langgenius/dify/security/code-scanning/111

To fix the problem, we need to parse the URL and ensure that the host is correctly validated. Instead of using startswith and endswith, we will use the urlparse function from the urllib.parse module to extract the hostname and validate it.

  1. Parse the URL using urlparse.
  2. Check if the hostname is "github.com".
  3. Ensure the path ends with ".yml" or ".yaml".
  4. Replace the URL parts to convert it to the raw GitHub URL if the checks pass.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

**Original Pull Request:** https://github.com/langgenius/dify/pull/12305 **State:** closed **Merged:** Yes --- Fixes [https://github.com/langgenius/dify/security/code-scanning/111](https://github.com/langgenius/dify/security/code-scanning/111) To fix the problem, we need to parse the URL and ensure that the host is correctly validated. Instead of using `startswith` and `endswith`, we will use the `urlparse` function from the `urllib.parse` module to extract the hostname and validate it. 1. Parse the URL using `urlparse`. 2. Check if the hostname is "github.com". 3. Ensure the path ends with ".yml" or ".yaml". 4. Replace the URL parts to convert it to the raw GitHub URL if the checks pass. _Suggested fixes powered by Copilot Autofix. Review carefully before merging._
yindo added the pull-request label 2026-02-21 20:41:49 -05:00
yindo closed this issue 2026-02-21 20:41:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?