langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12404] Enable scrolling to address Issue#12308 #27622

New Issue
Closed
opened 2026-02-21 20:41:53 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:53 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12404

State: closed
Merged: No

Summary of Changes Made to Enable Scrolling in VarPanel

  1. Container Structure: The main container of the VarPanel component was structured to allow scrolling by ensuring that the outer container has a defined maximum height (maxHeight: '400px') and uses overflow-y-auto to enable vertical scrolling.

  2. Scrollable Areas:

    • The inner content area that displays the variable list and uploaded images was set to be scrollable by applying overflow-y-auto and a maximum height to ensure that it can scroll when the content exceeds the visible area.
    • The value area for each variable was also given a maximum height and overflowY: 'auto' to allow scrolling for long text values.

  3. CSS Classes: Ensured that the appropriate CSS classes (overflow-y-auto, max-h-60, etc.) were applied correctly to avoid any conflicts that might prevent scrolling.

Result

These changes ensure that users can scroll through the content of the VarPanel, including the variable list and any long text values, enhancing usability and accessibility.

Close #12308

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12404 **State:** closed **Merged:** No --- ### Summary of Changes Made to Enable Scrolling in `VarPanel` 1. **Container Structure**: The main container of the `VarPanel` component was structured to allow scrolling by ensuring that the outer container has a defined maximum height (`maxHeight: '400px'`) and uses `overflow-y-auto` to enable vertical scrolling. 2. **Scrollable Areas**: - The inner content area that displays the variable list and uploaded images was set to be scrollable by applying `overflow-y-auto` and a maximum height to ensure that it can scroll when the content exceeds the visible area. - The value area for each variable was also given a maximum height and `overflowY: 'auto'` to allow scrolling for long text values. 3. **CSS Classes**: Ensured that the appropriate CSS classes (`overflow-y-auto`, `max-h-60`, etc.) were applied correctly to avoid any conflicts that might prevent scrolling. ### Result These changes ensure that users can scroll through the content of the `VarPanel`, including the variable list and any long text values, enhancing usability and accessibility. Close #12308 > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:53 -05:00
yindo closed this issue 2026-02-21 20:41:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?