langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12514] feat: add ci job to test template for docker compose #27661

New Issue
Closed
opened 2026-02-21 20:41:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:41:57 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12514

State: closed
Merged: Yes

Summary

This PR introduce new CI test in Style check to test compose file and its template are in sync.
This test fails if the docker-compose.yaml and docker-compose-template.yaml are not in sync,

  • Triggered if the changes are in:
    • docker/generate_docker_compose
    • docker/.env.example
    • docker/docker-compose-template.yaml
    • docker/docker-compose.yaml
  • Invokes generate_docker_compose
  • If any changes are detected by git diff, the test will be failed. If not, the test will be passed

Closes #12505

Demos

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12514 **State:** closed **Merged:** Yes --- # Summary This PR introduce new CI test in `Style check` to test compose file and its template are in sync. This test fails if _**the docker-compose.yaml and docker-compose-template.yaml are not in sync**_, - Triggered if the changes are in: - docker/generate_docker_compose - docker/.env.example - docker/docker-compose-template.yaml - docker/docker-compose.yaml - Invokes `generate_docker_compose` - If any changes are detected by `git diff`, the test will be failed. If not, the test will be passed Closes #12505 # Demos - ✅ No changes on above four files: not triggered: - https://github.com/kurokobo/dify/actions/runs/12672961281/job/35318192941 - 🚨 Changes are made, and the files are not in sync: - only templae file is updated, so there is diff on docker-compose.yaml (added lines) - https://github.com/kurokobo/dify/actions/runs/12673119362/job/35318742314 - 🚨 Changes are made, and the files are not in sync: - only compose file is updated, so there is diff on docker-compose.yaml (removed lines) - https://github.com/kurokobo/dify/actions/runs/12673161796/job/35318908533 - ✅ Changes are made, and the files are in sync - https://github.com/kurokobo/dify/actions/runs/12673225163/job/35319129415 # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:41:57 -05:00
yindo closed this issue 2026-02-21 20:41:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?