langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12704] fix: fix the formatter is not applied on log file #27722

New Issue
Closed
opened 2026-02-21 20:42:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12704

State: closed
Merged: Yes

Summary

Fixes https://github.com/langgenius/dify/issues/12744.

In https://github.com/langgenius/dify/pull/11599, the patch removed the formatter from basicConfig and added it only to the stdout, however, the log file requires formatter as well. This patch adds the formatter back.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

In log files:

Before:

INFO:root:Loaded ext_storage (364.46 ms)
INFO:root:Loaded ext_celery (1.46 ms)
INFO:root:Loaded ext_login (0.01 ms)
INFO:root:Skipped ext_mail
INFO:root:Loaded ext_hosting_provider (0.0 ms)
INFO:root:Loaded ext_sentry (0.0 ms)
INFO:root:Loaded ext_proxy_fix (0.0 ms)
INFO:root:Loaded ext_blueprints (373.1 ms)
INFO:root:Loaded ext_commands (1.6 ms)
INFO:root:Finished create_app (11808.69 ms)
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on all addresses (0.0.0.0)
 * Running on http://127.0.0.1:5001
 * Running on http://x.x.x.x:5001
INFO:werkzeug:Press CTRL+C to quit

After:

2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_celery (2.81 ms)
2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_login (0.02 ms)
2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:83] - Skipped ext_mail
2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_hosting_provider (0.01 ms)
2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_sentry (0.0 ms)
2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_proxy_fix (0.0 ms)
2025-01-14 23:45:22,001.001 INFO [MainThread] [app_factory.py:90] - Loaded ext_blueprints (364.07 ms)
2025-01-14 23:45:22,003.003 INFO [MainThread] [app_factory.py:90] - Loaded ext_commands (1.27 ms)
2025-01-14 23:45:22,003.003 INFO [MainThread] [app_factory.py:28] - Finished create_app (6042.56 ms)
2025-01-14 23:45:22,008.008 INFO [MainThread] [_internal.py:97] - WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on all addresses (0.0.0.0)
 * Running on http://127.0.0.1:5001
 * Running on http://x.x.x.x:5001
2025-01-14 23:45:22,008.008 INFO [MainThread] [_internal.py:97] - Press CTRL+C to quit

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12704 **State:** closed **Merged:** Yes --- # Summary Fixes https://github.com/langgenius/dify/issues/12744. In https://github.com/langgenius/dify/pull/11599, the patch removed the formatter from `basicConfig` and added it only to the `stdout`, however, the log file requires formatter as well. This patch adds the formatter back. > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots In log files: Before: ``` INFO:root:Loaded ext_storage (364.46 ms) INFO:root:Loaded ext_celery (1.46 ms) INFO:root:Loaded ext_login (0.01 ms) INFO:root:Skipped ext_mail INFO:root:Loaded ext_hosting_provider (0.0 ms) INFO:root:Loaded ext_sentry (0.0 ms) INFO:root:Loaded ext_proxy_fix (0.0 ms) INFO:root:Loaded ext_blueprints (373.1 ms) INFO:root:Loaded ext_commands (1.6 ms) INFO:root:Finished create_app (11808.69 ms) INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead. * Running on all addresses (0.0.0.0) * Running on http://127.0.0.1:5001 * Running on http://x.x.x.x:5001 INFO:werkzeug:Press CTRL+C to quit ``` After: ``` 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_celery (2.81 ms) 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_login (0.02 ms) 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:83] - Skipped ext_mail 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_hosting_provider (0.01 ms) 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_sentry (0.0 ms) 2025-01-14 23:45:21,637.637 INFO [MainThread] [app_factory.py:90] - Loaded ext_proxy_fix (0.0 ms) 2025-01-14 23:45:22,001.001 INFO [MainThread] [app_factory.py:90] - Loaded ext_blueprints (364.07 ms) 2025-01-14 23:45:22,003.003 INFO [MainThread] [app_factory.py:90] - Loaded ext_commands (1.27 ms) 2025-01-14 23:45:22,003.003 INFO [MainThread] [app_factory.py:28] - Finished create_app (6042.56 ms) 2025-01-14 23:45:22,008.008 INFO [MainThread] [_internal.py:97] - WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead. * Running on all addresses (0.0.0.0) * Running on http://127.0.0.1:5001 * Running on http://x.x.x.x:5001 2025-01-14 23:45:22,008.008 INFO [MainThread] [_internal.py:97] - Press CTRL+C to quit ``` # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:04 -05:00
yindo closed this issue 2026-02-21 20:42:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27722
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?