langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #12693] fix:Improve MIME type detection for remote URL uploads using python-magic #27725

New Issue
Closed
opened 2026-02-21 20:42:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/12693

State: closed
Merged: Yes

Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to application/octet-stream. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads.

Summary

Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to application/octet-stream. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads.

Fixes #12551

Dependency Check

  • python-magic is implicitly available as a transitive dependency (via another package), so no additional changes to pyproject.toml or poetry.lock are required.

Checklist

Important

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/12693 **State:** closed **Merged:** Yes --- Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to `application/octet-stream`. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads. # Summary Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to `application/octet-stream`. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads. Fixes #12551 ## Dependency Check - `python-magic` is implicitly available as a transitive dependency (via another package), so no additional changes to `pyproject.toml` or `poetry.lock` are required. # Checklist > [!IMPORTANT] - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:04 -05:00
yindo closed this issue 2026-02-21 20:42:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?