langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #13101] fix: add install a package to improve the accuracy of guessing mime type and file extension (plugins/beta) #27838

New Issue
Closed
opened 2026-02-21 20:42:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/13101

State: closed
Merged: No

Summary

This is for plugins/beta branch.

This PR installs media-types package to improve the accuracy of guessing mime type and file extension.
When creating a file in the tool plugin, we can specify the mime type for the file, but due to the lack of media-types package, even if we provide the correct mime type, the file extension may become .bin in some cases.

Closes #13717

The same PR for main branch: https://github.com/langgenius/dify/pull/13752

Screenshots

Before
Without media-types, mimetypes module in Python cannot guess the extension for the specific mime types:
image

After
By installing media-types package, the extension for the specific mime types can be guessed:
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/13101 **State:** closed **Merged:** No --- # Summary **This is for `plugins/beta` branch.** This PR installs `media-types` package to improve the accuracy of guessing mime type and file extension. When creating a file in the tool plugin, we can specify the mime type for the file, but due to the lack of `media-types` package, even if we provide the correct mime type, the file extension may become `.bin` in some cases. Closes #13717 The same PR for `main` branch: https://github.com/langgenius/dify/pull/13752 # Screenshots **Before** Without `media-types`, `mimetypes` module in Python cannot guess the extension for the specific mime types: ![image](https://github.com/user-attachments/assets/ff965c4b-f029-4165-95a2-de06d6bc0e7c) **After** By installing `media-types` package, the extension for the specific mime types can be guessed: ![image](https://github.com/user-attachments/assets/93add220-c5c6-457b-a13d-87ab9615ddb4) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:18 -05:00
yindo closed this issue 2026-02-21 20:42:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27838
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?