langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-25 21:47:07 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #13155] fix: set indexing technique from dataset during update-by-text #27852

New Issue
Closed
opened 2026-02-21 20:42:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/13155

State: closed
Merged: Yes

Summary

This PR fixes an invalid_param error in the update-by-text API endpoint.
The error occurs when indexing_technique is not provided to the KnowledgeConfig validation, resulting in a Pydantic validation error.

Example of the current error:

curl --location --request POST 'http://127.0.0.1:5001/v1/datasets/UUID_HERE/documents/UUID_HERE/update-by-text' \
--header 'Authorization: Bearer API_KEY_HERE' \
--header 'Content-Type: application/json' \
--data-raw '{"name": "name2","text": "text"}'

Response:

{
    "code": "invalid_param",
    "message": "1 validation error for KnowledgeConfig\nindexing_technique\n  Field required [type=missing, input_value={'name': 'name2', 'text':...4da8-9a39-a78f4108669a'}, input_type=dict]\n    For further information visit https://errors.pydantic.dev/2.9/v/missing",
    "status": 400
}

The indexing_technique parameter is only meant to be set during document creation or initial upload, as shown in the current dataset_service implementation. For update operations, this field should not be required since it's already set and immutable.

This PR fixes the issue by defaulting to the dataset's existing indexing_technique value in the update API endpoint.

resolves #12465

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/13155 **State:** closed **Merged:** Yes --- # Summary This PR fixes an `invalid_param` error in the `update-by-text` API endpoint. The error occurs when `indexing_technique` is not provided to the `KnowledgeConfig` validation, resulting in a Pydantic validation error. Example of the current error: ```curl curl --location --request POST 'http://127.0.0.1:5001/v1/datasets/UUID_HERE/documents/UUID_HERE/update-by-text' \ --header 'Authorization: Bearer API_KEY_HERE' \ --header 'Content-Type: application/json' \ --data-raw '{"name": "name2","text": "text"}' ``` Response: ```json { "code": "invalid_param", "message": "1 validation error for KnowledgeConfig\nindexing_technique\n Field required [type=missing, input_value={'name': 'name2', 'text':...4da8-9a39-a78f4108669a'}, input_type=dict]\n For further information visit https://errors.pydantic.dev/2.9/v/missing", "status": 400 } ``` The `indexing_technique` parameter is only meant to be set during document creation or initial upload, as shown in the [current dataset_service implementation](https://github.com/langgenius/dify/blob/main/api/services/dataset_service.py#L789). For update operations, this field should not be required since it's already set and immutable. This PR fixes the issue by defaulting to the dataset's existing `indexing_technique` value in the update API endpoint. resolves #12465 # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:19 -05:00
yindo closed this issue 2026-02-21 20:42:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?