langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-27 03:01:54 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #13260] fix: correct linewrap think display in generic openai api #27894

New Issue
Closed
opened 2026-02-21 20:42:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:24 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/13260

State: closed
Merged: Yes

Summary

Follow up #13234.

I've got keys from deepseek and siliconflow. Thus I tested and removed duplicated code.

I also found two corner cases and one bug:

  1. \n\n..\n may be there. That said you can't just replace \n\n but also \n in the same line. I made a regexp replace.
  2. both reasoning_content and content may be empty sometimes in the thinking phase. the current code will terminate the reasoning phase, append > think_icon again.
  3. delta_content is not assigned correctly in the generic openai api module.

Since official deepseek api does not respond after fixing problem 2, I don't have screen shots for it.

Screenshots

Before After
... Screenshot 2025-02-06 at 10-32-58 test - Dify
... Screenshot 2025-02-06 at 10-34-34 test - Dify
... Screenshot 2025-02-06 at 10-41-53 test - Dify

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/13260 **State:** closed **Merged:** Yes --- # Summary Follow up #13234. I've got keys from deepseek and siliconflow. Thus I tested and removed duplicated code. I also found two corner cases and one bug: 1. `\n\n..\n` may be there. That said you can't just replace `\n\n` but also `\n` in the same line. I made a regexp replace. 2. both `reasoning_content` and `content` may be empty sometimes in the thinking phase. the current code will terminate the reasoning phase, append `> think_icon` again. 3. `delta_content` is not assigned correctly in the generic openai api module. Since official deepseek api does not respond after fixing `problem 2`, I don't have screen shots for it. # Screenshots | Before | After | |--------|-------| | ... | ![Screenshot 2025-02-06 at 10-32-58 test - Dify](https://github.com/user-attachments/assets/733a5d43-9891-43ba-9cd0-e849b6ff905e) | | ... | ![Screenshot 2025-02-06 at 10-34-34 test - Dify](https://github.com/user-attachments/assets/f04f66bc-9e7a-43f0-b22c-6e2f1204e828) | | ... | ![Screenshot 2025-02-06 at 10-41-53 test - Dify](https://github.com/user-attachments/assets/179c2483-75aa-47c5-a281-d1db60681208) | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:24 -05:00
yindo closed this issue 2026-02-21 20:42:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27894
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?