langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-26 18:36:52 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #13432] chore: use the wrap thinking api for volcengine #27959

New Issue
Closed
opened 2026-02-21 20:42:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/13432

State: closed
Merged: Yes

Summary

As title, and also a bug fix.

#13299 had reverted one behavior I made in #13260, specifically, the problem 2, which is kinda common in some API(siliconflow and one generic provider I am using).

The whole reasoning content were cut into three pieces of <think></think> with disconnected sentences, because there was one single response with both empty reasoning_content and content, which ended the reasoning just in the middle unexpectedly.

Screenshots

Before After
... 图片

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/13432 **State:** closed **Merged:** Yes --- # Summary As title, and also a bug fix. #13299 had reverted one behavior I made in #13260, specifically, the problem 2, which is kinda common in some API(siliconflow and one generic provider I am using). The whole reasoning content were cut into three pieces of `<think></think>` with disconnected sentences, because there was one single response with both empty reasoning_content and content, which ended the reasoning just in the middle unexpectedly. # Screenshots | Before | After | |--------|-------| | ... | ![图片](https://github.com/user-attachments/assets/f9002738-dcda-4f5f-925d-1710155ae99f) | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:31 -05:00
yindo closed this issue 2026-02-21 20:42:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#27959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?