langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #14243] fix: datasets documents update-by-file api missing assign field 'indexing_technique' internally #28138

New Issue
Closed
opened 2026-02-21 20:42:52 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:42:52 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/14243

State: closed
Merged: Yes

Summary

when post /datasets/{dataset_id}/documents/{document_id}/update-by-file with only name and file filed, i got error:

{
  "code": "invalid_param",
  "message": "1 validation error for KnowledgeConfig\nindexing_technique\n  Field required [type=missing, input_value={'doc_form': 'text_model'...45c5-b58f-642ae837a9b9'}, input_type=dict]\n    For further information visit https://errors.pydantic.dev/2.9/v/missing",
  "status": 400
}

this pr fix this problem just like https://github.com/langgenius/dify/blob/7790214620c653a6f6c19c402969a0474a3e5778/api/controllers/service_api/dataset/document.py#L146-L147 do

to fix https://github.com/langgenius/dify/issues/14266

Screenshots

see Summary

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/14243 **State:** closed **Merged:** Yes --- # Summary when post `/datasets/{dataset_id}/documents/{document_id}/update-by-file` with only `name` and `file` filed, i got error: ```json { "code": "invalid_param", "message": "1 validation error for KnowledgeConfig\nindexing_technique\n Field required [type=missing, input_value={'doc_form': 'text_model'...45c5-b58f-642ae837a9b9'}, input_type=dict]\n For further information visit https://errors.pydantic.dev/2.9/v/missing", "status": 400 } ``` this pr fix this problem just like https://github.com/langgenius/dify/blob/7790214620c653a6f6c19c402969a0474a3e5778/api/controllers/service_api/dataset/document.py#L146-L147 do to fix https://github.com/langgenius/dify/issues/14266 # Screenshots see [Summary](#Summary) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [x] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:42:52 -05:00
yindo closed this issue 2026-02-21 20:42:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#28138
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?