langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #15872] fix: correct pagination logic in all-workspace API #28395

New Issue
Closed
opened 2026-02-21 20:43:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:43:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/15872

State: closed
Merged: No

Summary

Fixes #15784
Fixed a TypeError in the WorkspaceListApi.get() method that occurred when trying to access a paginated query result with a subscript operator.
The issue was in /app/api/controllers/console/workspace/workspace.py, line 95, where the code was incorrectly trying to access tenants[-1] directly, but tenants is a pagination object, not a subscriptable list.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/15872 **State:** closed **Merged:** No --- # Summary Fixes #15784 Fixed a TypeError in the WorkspaceListApi.get() method that occurred when trying to access a paginated query result with a subscript operator. The issue was in `/app/api/controllers/console/workspace/workspace.py`, line 95, where the code was incorrectly trying to access `tenants[-1]` directly, but `tenants` is a pagination object, not a subscriptable list. # Screenshots | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/57d1b3c9-10af-4555-87fd-fd862a846185) | ![image](https://github.com/user-attachments/assets/577ca6a6-ee08-4e73-a5c6-6cf9ab2785d4) | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:43:22 -05:00
yindo closed this issue 2026-02-21 20:43:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#28395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?