langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #17430] fix: keep image url #28700

New Issue
Closed
opened 2026-02-21 20:43:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:43:57 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/17430

State: closed
Merged: Yes

Summary

Close https://github.com/langgenius/dify/issues/17447.

This PR changes the behavior of "Delete all URLs and email addresses" option.

Before this PR, if "Delete all URLs and email addresses" was checked, image links would be lost.

After this PR, if "Delete all URLs and email addresses" is checked, image links will be preserved.

Screenshots

Before After
Before this PR, if "Delete all URLs and email addresses" was checked, image links would be lost. image After this PR, if "Delete all URLs and email addresses" is checked, image links will be preserved. image

test.docx

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/17430 **State:** closed **Merged:** Yes --- # Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. --> Close https://github.com/langgenius/dify/issues/17447. This PR changes the behavior of "Delete all URLs and email addresses" option. Before this PR, if "Delete all URLs and email addresses" was checked, image links would be lost. After this PR, if "Delete all URLs and email addresses" is checked, image links will be preserved. # Screenshots | Before | After | |--------|-------| | Before this PR, if "Delete all URLs and email addresses" was checked, image links would be lost. <img width="1512" alt="image" src="https://github.com/user-attachments/assets/dfeb389f-a17e-4641-a001-ea2e07673d83" /> | After this PR, if "Delete all URLs and email addresses" is checked, image links will be preserved. <img width="1512" alt="image" src="https://github.com/user-attachments/assets/597a3ac1-7073-4c83-a012-7ab813c489c3" /> | [test.docx](https://github.com/user-attachments/files/19588179/test.docx) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:43:57 -05:00
yindo closed this issue 2026-02-21 20:43:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#28700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?