langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #18197] fix: change the method of update_dataset api in document #28858

New Issue
Closed
opened 2026-02-21 20:44:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:15 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/18197

State: closed
Merged: Yes

Summary

The API documentation of the knowledge base provides an incorrect HTTP request method for the update_dataset interface. The documentation shows POST, but PATCH is used in the code. Additionally, the documentation incorrectly describes the type of the retrieval_model parameter for the update_dataset interface; it should be of Object type.

image

Screenshots

Doc Code
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/18197 **State:** closed **Merged:** Yes --- # Summary The API documentation of the knowledge base provides an incorrect HTTP request method for the `update_dataset` interface. The documentation shows `POST`, but `PATCH` is used in the code. Additionally, the documentation incorrectly describes the type of the `retrieval_model` parameter for the `update_dataset` interface; it should be of `Object` type. <img width="512" alt="image" src="https://github.com/user-attachments/assets/db081cc7-3df0-414b-bdc3-1a8ccf26cdc5" /> # Screenshots | Doc | Code | |--------|-------| | <img width="512" alt="image" src="https://github.com/user-attachments/assets/b4383818-66cc-4ac1-a815-183ce0a096d9" /> | <img width="512" alt="image" src="https://github.com/user-attachments/assets/fe156b2a-e3c5-4f76-9373-75126b9505d6" /> | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:15 -05:00
yindo closed this issue 2026-02-21 20:44:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#28858
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?