[PR #18864] fix: update notice for users for clear-orphaned-file-records and remove-orphaned-files-on-storage commands #29012

Closed
opened 2026-02-21 20:44:42 -05:00 by yindo · 0 comments
Owner

Original Pull Request: https://github.com/langgenius/dify/pull/18864

State: closed
Merged: Yes


Summary

This is follow-up for #18835 to improve notice for users.

  • The backup to be obtained before proceeding remove-orphaned-files-on-storage command should be from storage, not the database. I have corrected the wording.
  • Since it may cause high load, I have made it display that running within the maintenance window is recommended.

Screenshots

Before After
image image
Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/18864 **State:** closed **Merged:** Yes --- # Summary This is follow-up for #18835 to improve notice for users. - The backup to be obtained before proceeding `remove-orphaned-files-on-storage` command should be from `storage`, not the `database`. I have corrected the wording. - Since it may cause high load, I have made it display that running within the maintenance window is recommended. # Screenshots | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/86d90c1d-15b1-46fe-b631-762544512af3) | ![image](https://github.com/user-attachments/assets/f657b219-ce07-457f-bcbe-a5757c4bb9bf) | | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/3975449a-8358-4bbf-a731-0d3a4bd25efd) | ![image](https://github.com/user-attachments/assets/70ead073-b1c2-4ded-a3e4-960a45d8b88e) | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:42 -05:00
yindo closed this issue 2026-02-21 20:44:42 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29012