langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-24 04:25:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #18930] if as_attachment is in the url, add it to the sign_url #29032

New Issue
Closed
opened 2026-02-21 20:44:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/18930

State: closed
Merged: Yes

Fixes #18921
‌Changes Made:‌

Modified the re_sign_file_url_answer method to include the as_attachment=True parameter when regenerating file URLs.
Ensured that the as_attachment parameter is preserved during URL re-signing to maintain correct file extension handling.
‌Testing:‌

Verified that downloaded files now retain their original extensions by checking both the before and after scenarios.
Added test cases to confirm that the as_attachment parameter is included in re-signed URLs.

**Original Pull Request:** https://github.com/langgenius/dify/pull/18930 **State:** closed **Merged:** Yes --- Fixes #18921 ‌Changes Made:‌ Modified the re_sign_file_url_answer method to include the as_attachment=True parameter when regenerating file URLs. Ensured that the as_attachment parameter is preserved during URL re-signing to maintain correct file extension handling. ‌Testing:‌ Verified that downloaded files now retain their original extensions by checking both the before and after scenarios. Added test cases to confirm that the as_attachment parameter is included in re-signed URLs.
yindo added the pull-request label 2026-02-21 20:44:44 -05:00
yindo closed this issue 2026-02-21 20:44:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?