langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #18945] fix: i.find is not a function #29041

New Issue
Closed
opened 2026-02-21 20:44:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:45 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/18945

State: closed
Merged: Yes

Summary

This pull request refactors utility functions in utils.ts to improve code readability and maintainability. The changes include restructuring the getIterationItemType function to simplify the loop logic and removing an unnecessary ESLint directive in the getLoopItemType function.

Refactoring for improved readability and maintainability:

  • getIterationItemType in utils.ts: Refactored the loop to use a for loop instead of forEach, added clearer variable naming, and simplified conditional checks for handling VarType.object and VarType.file. This improves the readability and structure of the function.

  • getLoopItemType in utils.ts: Removed an unused ESLint directive (// eslint-disable-next-line sonarjs/no-identical-functions) to clean up the code.

Close https://github.com/langgenius/dify/issues/18937
Close https://github.com/langgenius/dify/issues/18836

Screenshots

Before After
... image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/18945 **State:** closed **Merged:** Yes --- # Summary This pull request refactors utility functions in `utils.ts` to improve code readability and maintainability. The changes include restructuring the `getIterationItemType` function to simplify the loop logic and removing an unnecessary ESLint directive in the `getLoopItemType` function. ### Refactoring for improved readability and maintainability: * `getIterationItemType` in `utils.ts`: Refactored the loop to use a `for` loop instead of `forEach`, added clearer variable naming, and simplified conditional checks for handling `VarType.object` and `VarType.file`. This improves the readability and structure of the function. * `getLoopItemType` in `utils.ts`: Removed an unused ESLint directive (`// eslint-disable-next-line sonarjs/no-identical-functions`) to clean up the code. Close https://github.com/langgenius/dify/issues/18937 Close https://github.com/langgenius/dify/issues/18836 # Screenshots | Before | After | |--------|-------| | ... | <img width="1109" alt="image" src="https://github.com/user-attachments/assets/9c9cd785-a004-41c7-bc83-118b21abd6c5" /> | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:45 -05:00
yindo closed this issue 2026-02-21 20:44:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?