langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #19208] fix: metadata filtering condition variable unassigned; fix External K… #29098

New Issue
Closed
opened 2026-02-21 20:44:52 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:52 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/19208

State: closed
Merged: Yes

Summary

fixes: #18365

  1. Improved the get_metadata_filter_condition function to resolve the unassigned variable issue in the metadata filtering condition logic, which fixed issue: #18365
  2. Refined the DatasetRetrieverTool invocation process to allow flexible metadata filtering through all metadata_filtering_mode (now metadata filtering works for both internal and external datasets ), which is a enhancement for PR #19020
  3. In addition, I think this PR may help to solve part of the problem #16349 , only improved backend query logics, it still requires the front-end to add relevant filtering parameters.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/19208 **State:** closed **Merged:** Yes --- # Summary fixes: #18365 1. Improved the `get_metadata_filter_condition` function to resolve the unassigned variable issue in the metadata filtering condition logic, which fixed issue: #18365 2. Refined the `DatasetRetrieverTool` invocation process to allow flexible metadata filtering through all `metadata_filtering_mode` (now metadata filtering works for both internal and external datasets ), which is a enhancement for PR #19020 3. In addition, I think this PR may help to solve part of the problem #16349 , only improved backend query logics, it still requires the front-end to add relevant filtering parameters. # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:52 -05:00
yindo closed this issue 2026-02-21 20:44:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?