langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #19504] chore: speed up api service startup time by defering the imports for trace services #29165

New Issue
Closed
opened 2026-02-21 20:44:59 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:44:59 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/19504

State: closed
Merged: Yes

Summary

  • to close #19505

  • saving 40% API service launch time (4627.76 ms -> 2812.27 ms on MacOS M4 Max), by deferring imports of tracing classes and SDK, which also helps to skip unnecessary network requests on starting introduced by Litellm from opik.

  • Before this PR:

    • ext_import_modules process takes 3406.33 ms
    ...
^[[A2025-05-11 15:43:27,216 INFO [_client.py:1038]  HTTP Request: GET https://raw.githubusercontent.com/BerriAI/litellm/main/model_prices_and_context_window.json "HTTP/1.1 200 OK"
2025-05-11 15:43:28,581 INFO [app_factory.py:99]  Loaded ext_import_modules (3406.33 ms)
...
2025-05-11 15:43:29,115 INFO [app_factory.py:35]  Finished create_app (4627.76 ms)

  • With this PR:

    • ext_import_modules process takes 1548.72 ms
    ...
2025-05-11 15:53:33,174 INFO [app_factory.py:99]  Loaded ext_import_modules (1548.72 ms)
...
2025-05-11 15:53:33,703 INFO [app_factory.py:35]  Finished create_app (2812.27 ms)

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/19504 **State:** closed **Merged:** Yes --- # Summary - to close #19505 - saving 40% API service launch time (4627.76 ms -> 2812.27 ms on MacOS M4 Max), by deferring imports of tracing classes and SDK, which also helps to skip unnecessary network requests on starting introduced by Litellm from opik. - Before this PR: - `ext_import_modules` process takes 3406.33 ms ``` ... ^[[A2025-05-11 15:43:27,216 INFO [_client.py:1038] HTTP Request: GET https://raw.githubusercontent.com/BerriAI/litellm/main/model_prices_and_context_window.json "HTTP/1.1 200 OK" 2025-05-11 15:43:28,581 INFO [app_factory.py:99] Loaded ext_import_modules (3406.33 ms) ... 2025-05-11 15:43:29,115 INFO [app_factory.py:35] Finished create_app (4627.76 ms) ``` - With this PR: - `ext_import_modules` process takes 1548.72 ms ``` ... 2025-05-11 15:53:33,174 INFO [app_factory.py:99] Loaded ext_import_modules (1548.72 ms) ... 2025-05-11 15:53:33,703 INFO [app_factory.py:35] Finished create_app (2812.27 ms) ``` # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:44:59 -05:00
yindo closed this issue 2026-02-21 20:44:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?