langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #19552] fix: common prerequisite node workflow remove reachable node that failed to streaming llm… #29172

New Issue
Closed
opened 2026-02-21 20:45:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:00 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/19552

State: closed
Merged: Yes

Summary

Fix #17626
Fix #16882
Fix #16826
Fix #15700
Fix #13264
(Maybe #17085)

LLM stream output needs node in self.rest_node_ids, but nodes is actually removed after common prerequisite branch node is executed. This should be solved by changing base_stream_processor.py/_remove_node_ids_in_unreachable_branch.

The change is very simple, figuring out where to fix it takes some time. Please take a look.

TODO:

  • add test case

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/19552 **State:** closed **Merged:** Yes --- # Summary Fix #17626 Fix #16882 Fix #16826 Fix #15700 Fix #13264 (Maybe #17085) LLM stream output needs node in [self.rest_node_ids](https://github.com/langgenius/dify/blob/14cd71ed0adbd60e1a51cd67f30572a3b650fefe/api/core/workflow/nodes/answer/answer_stream_processor.py#L42C16-L53C32), but nodes is actually [removed](https://github.com/langgenius/dify/blob/14cd71ed0adbd60e1a51cd67f30572a3b650fefe/api/core/workflow/nodes/answer/base_stream_processor.py#L23) after common prerequisite branch node is executed. This should be solved by changing `base_stream_processor.py/_remove_node_ids_in_unreachable_branch`. The change is very simple, figuring out where to fix it takes some time. Please take a look. TODO: - [ ] add test case > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:00 -05:00
yindo closed this issue 2026-02-21 20:45:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?